Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Helper functions for Kubernetes ReplicaSets #793

Closed
cbuto opened this issue Feb 23, 2021 · 2 comments · Fixed by #804
Closed

Feature Request: Helper functions for Kubernetes ReplicaSets #793

cbuto opened this issue Feb 23, 2021 · 2 comments · Fixed by #804
Labels
enhancement New feature or request

Comments

@cbuto
Copy link
Contributor

cbuto commented Feb 23, 2021

I'm not sure if this would pass the litmus tests defined in the contributor guide but I think it might be something worthwhile supporting in Terratest in terms of popularity/completeness.

We have tests implemented currently that rely on the outcome of creating deployments and assertions based on the associated ReplicaSet events.

This would look much the daemonset implementation.

Let me know if this is something that sounds reasonable!

P.S Terratest has significantly improved our existing testing strategy, so I really appreciate this project and support from the maintainers!

@brikis98 brikis98 added enhancement New feature or request help wanted labels Mar 9, 2021
@brikis98
Copy link
Member

brikis98 commented Mar 9, 2021

Makes sense to me and I think a PR would make sense. @yorinasub17 Any objections?

@yorinasub17
Copy link
Contributor

No objections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants