Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appserviceplan azure module in a similar fashion to compute #548

Open
tsalright opened this issue Jun 5, 2020 · 5 comments
Open

Add appserviceplan azure module in a similar fashion to compute #548

tsalright opened this issue Jun 5, 2020 · 5 comments

Comments

@tsalright
Copy link

I would like to start building out some additional modules for Azure. I am building a lot of terraform modules for my company and want to add some details tests to validate sku, kind, reserved, and tags. I would like to contribute a module that follows the pattern established by the compute module that provides functions to retrieve the pieces from Azure.

func GetSkuOfAppServicePlan and func GetSkuOfAppServicePlanE
func GetKindOfAppServicePlan and func GetKindOfAppServicePlanE
func GetReservedOfAppServicePlan and func GetReservedOfAppServicePlanE
func GetTagsOfAppServicePlan and func GetTagsOfAppServicePlanE

Then in my tests I would simply consume these:

sku := azure.GetSkuOfAppServicePlan(t, planName, resGroupName, subscriptionID)
kind := azure.GetKindOfAppServicePlan(t, planName, resGroupName, subscriptionID)
reserved := azure.GetReservedOfAppServicePlan(t, planName, resGroupName, subscriptionID)
tags := azure.GetTagsOfAppServicePlan(t, planName, resGroupName, subscriptionID)

@tsalright
Copy link
Author

Here is my terraform and tests I am writing where I would like to have this feature available if it helps to have context for this discussion.

@tsalright
Copy link
Author

I also see that test automation for Azure isn't setup.

// NOTE: We use build tags to differentiate azure testing because we currently do not have azure access setup for

I would like to write some tests for this module. What is the timeline for having CircleCI setup for Azure testing? I would be happy to help any way I can. I just setup our pipelines in Azure DevOps to connect to a test subscription to run my terratest validations.

@tsalright
Copy link
Author

@yorinasub17 Any thoughts on this? I have a team actively building out azure modules and we would love to contribute to the Azure testing modules here.

@brikis98
Copy link
Member

@tsalright More Azure contributions would be great, but please see here for the current context, and feel free to join the conversation! #89 (comment)

@brikis98
Copy link
Member

Please see #89 for the status on Terratest with Azure. In particular, we're starting some work around it, and when that work is done, we'll be able to come back to this question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants