Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terratest fails for azure modules with "features": required field is not set" #534

Closed
papineni87 opened this issue May 27, 2020 · 8 comments
Labels
Azure bug Something isn't working

Comments

@papineni87
Copy link

I am trying to test terraform azure module and facing below issue

TestTerraformAzureExample 2020-05-27T21:22:08+05:30 logger.go:66: 2020/05/27 21:22:08 [ERROR] : eval: *terraform.EvalSequence, err: "features": required field is not set
TestTerraformAzureExample 2020-05-27T21:22:08+05:30 logger.go:66:
TestTerraformAzureExample 2020-05-27T21:22:08+05:30 logger.go:66: Error: "features": required field is not set

I am not sure why features field is required for modules as it is required only in the provider.
I am not using the azurerm provider in my modules.

@brikis98 brikis98 added bug Something isn't working help wanted labels May 31, 2020
@brikis98
Copy link
Member

Hm, looks like the Azurerm 2.0 provider now requires the features block to be set: hashicorp/terraform-provider-azurerm#5867.

Would you be up for a PR to add that to the Azure examples?

@tsalright
Copy link

The example I am seeing in the code is pointed to azurerm 1.31.0. It shouldn't require the feature field.

Locally, I ran the test straight from master and it works. I updated it to version 2.0.0 and ran it against my azure account without feature and was able to replicate the issue. I then added features {} on the next line and the tests are working for provider 2.0.0.

I threw a pull request together while i was testing it out.
#547

@brikis98 brikis98 added the Azure label Jun 26, 2020
@brikis98
Copy link
Member

Please see #89 for the status on Terratest with Azure. In particular, we're starting some work around it, and when that work is done, we'll be able to come back to this question!

@davesee
Copy link
Contributor

davesee commented Feb 6, 2021

Hi @tsalright ,

Are you still having the problem? I see features{} is now included in the providers.

There have been several updates to the Azure tests since this issue was created and I would like to help if it is still needed.

@tsalright
Copy link

@davesee I am not having the issue anymore. I think we updated most of these when we restructured the modules and tests. Should be good now.

@davesee
Copy link
Contributor

davesee commented Feb 11, 2021

Please close @yorinasub17

@HadwaAbdelhalem
Copy link
Contributor

@brikis98 would you please close this issue. the recent contributions fixed that

@yorinasub17
Copy link
Contributor

Thanks for the updates! Just closed as requested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants