Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Mocking Strategy for module libraries #481

Closed
TsuyoshiUshio opened this issue Mar 23, 2020 · 2 comments
Closed

Question: Mocking Strategy for module libraries #481

TsuyoshiUshio opened this issue Mar 23, 2020 · 2 comments
Labels
awaiting response Waiting for a response or more data from issue reporter question

Comments

@TsuyoshiUshio
Copy link
Contributor

Hello,

I have a question about the mocking strategy. In the module directory, I can find the test. However, I can't see any mock related testing.
I'm planning to contribute this repo for the azure related new modules,
Do you have any preference for a mocking strategy for the module unit testing?

For example, I usually use Monkey Patch https://github.com/bouk/monkey .

@rguthriemsft @QuickNS

@brikis98
Copy link
Member

To answer your main question, I don't think we are using any mocking libraries right now. Monkey Patching also seems... risky. What use case did you have in mind for that?

You also mentioned adding support for Azure modules. Please be sure to read this: #89 (comment)

@zackproser zackproser added the awaiting response Waiting for a response or more data from issue reporter label Apr 16, 2020
@no-response
Copy link

no-response bot commented May 16, 2020

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please feel free to reach out if you have or find the answers we need so that we can investigate further. Thank you!

@no-response no-response bot closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Waiting for a response or more data from issue reporter question
Projects
None yet
Development

No branches or pull requests

3 participants