Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable helm dependency build on template rendering #1143

Closed
curuvija opened this issue Jun 22, 2022 · 3 comments · Fixed by #1289
Closed

Disable helm dependency build on template rendering #1143

curuvija opened this issue Jun 22, 2022 · 3 comments · Fixed by #1289
Labels
p:needs triage Needs to be processed by maintainer and issue type / priority added

Comments

@curuvija
Copy link

Hi,

I'm running a loop rendering more than a few templates and on each 'helm dependency build' command is executed which slows down the execution of tests. Here I see:

if _, err := RunHelmCommandAndGetOutputE(t, &Options{}, "dependency", "build", chartDir); err != nil {

Could we have an option to disable this and in that case I could probably do something like this:

helm.RenderTemplate(s.T(), options, s.ChartPath, s.Release, s.Templates, "--dependency-update")

This will download dependencies only once.

Is there an another way to solve this issue that I'm not aware off?

There is one similar issue already created here #342.

@denis256 denis256 added the p:needs triage Needs to be processed by maintainer and issue type / priority added label Jul 4, 2022
@Jeinhaus
Copy link

In our case our test cases are now failing, since we download dependencies from a private Helm repository before executing the tests. It would be great if this feature was optional so we don't have to modify all our tests to be able to pull from our private repositories.

@nieomylnieja
Copy link

I agree, there are similar issues already: #1193 (comment)

@rshutt-va
Copy link

rshutt-va commented May 10, 2023

I'm cross-posting this from #1193. To further address the "default behavior" concern, should not the default behavior of Template and Install have some parity?

Even more strange is the helm.Install workflow does not do ANY dep build; the user must do this before installing (typically for an integration test). It is counterintuitive to have the Template workflow forcibly do the helm dep build vs. the Install workflow not doing it. My preferred solution would be to have the Template workflow omit the dep build, and I'd suggest the user is instructed to do the dep build before any Template workflow as it is with the Install workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:needs triage Needs to be processed by maintainer and issue type / priority added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants