Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port grpc-web interop tests from old repo #828

Open
johanbrandhorst opened this issue May 29, 2020 · 1 comment
Open

Port grpc-web interop tests from old repo #828

johanbrandhorst opened this issue May 29, 2020 · 1 comment

Comments

@johanbrandhorst
Copy link
Collaborator

I'm very pleased to see interop tests are now part of the official repo, and I can deprecate my old interop test repo. However, there are still a few clients and proxies represented in this repo which haven't yet been ported across, for example:

  • The Improbable grpc-web client.
  • The Improbable Go grpc-web proxy (standalone and in-process).
  • The akka-grpc Scala proxy (credit @timw),
  • The grpcwsgi Python proxy (credit @public).

Fortunately, all of these should be quite easy to port, as they are already packaged in independent Dockerfiles, with a setup much like the one here.

It would also be nice if we could port the existing compatibility status matrix, since I think it gives a nice overview, and would be nice to carry forward.

@timw
Copy link

timw commented May 30, 2020

Minor correction, akka-grpc implements grpc-web directly in its gRPC stack, so it's not a proxy.
i.e. it will require a reimplementation of the echo service used by the tests in akka-grpc.

In the old interop repo, I implemented this entirely in the Docker build so it's self contained - I'm happy to port this if there's consensus to include interop with other server implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants