-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-js: Fix pick_first reconnecting without active calls #2784
Merged
murgatroid99
merged 3 commits into
grpc:@grpc/[email protected]
from
murgatroid99:grpc-js_pick_first_reconnection_fix
Jul 10, 2024
Merged
grpc-js: Fix pick_first reconnecting without active calls #2784
murgatroid99
merged 3 commits into
grpc:@grpc/[email protected]
from
murgatroid99:grpc-js_pick_first_reconnection_fix
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Jul 3, 2024
murgatroid99
merged commit Jul 10, 2024
f8338c5
into
grpc:@grpc/[email protected]
4 of 5 checks passed
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at fixing #2718. The previous attempt, #2680, failed because of #2690. I believe I have fixed that this time. With the original change, I reproduced a failure like the one reported: if the server dropped each connection after 1 second, and the client made requests as quickly as possible, after only a couple of minutes the client would entirely stop attempting to reconnect. With the change to handle ready subchannels in
connectToAddressList
, I ran the same test for half an hour without any problem.