netty: Removed 4096 min buffer size #11856
Conversation
There was a problem hiding this comment.
We need to include more context. At the very least this (the commit and the PR description) should have a "Fixes #11719" to associate it with the issue (and it will also auto-close the issue when merging). But we should also summarize why we are making the change. I'd say something like, "MessageFramer.flush() is being called between every message, so messages are never combined and the larger allocation just wastes memory."
netty/src/test/java/io/grpc/netty/NettyWritableBufferAllocatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
You'll want to "squash and merge" using the github button. It will give you the opportunity to write the commit message, and you'll want to clean it up, because it gives a very poor default (it is a useful default, as it gives you all the words you may want to adjust, but it will need editing).
Yeah, looks like you'll want to copy from your PR description to fill in the commit description. |
Fixes #11719
MessageFramer.flush() is being called between every message, so messages are never combined and the larger allocation just wastes memory. The change removes the restriction on the min buffer size and hence, prevents the said wastage.