Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive linter doesn't check submodules #8021

Closed
arjan-bal opened this issue Jan 20, 2025 · 1 comment · Fixed by #8029
Closed

revive linter doesn't check submodules #8021

arjan-bal opened this issue Jan 20, 2025 · 1 comment · Fixed by #8029
Assignees
Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Bug

Comments

@arjan-bal
Copy link
Contributor

It was pointed out in #7994 that the revive linter setup in vet.sh runs only against the main module

grpc-go/scripts/vet.sh

Lines 195 to 202 in eb7c484

# Error for violation of enabled lint rules in config excluding generated code.
revive \
-set_exit_status=1 \
-exclude "testdata/grpc_testing_not_regenerated/" \
-exclude "**/*.pb.go" \
-formatter plain \
-config "$(dirname "$0")/revive.toml" \
./...

We should enable revive for submodules and fix and any errors that it flags.

@arjan-bal arjan-bal added Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Bug labels Jan 20, 2025
@vinothkumarr227
Copy link
Contributor

@purnesh42H please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants