Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【QA】When to publish a new Release? #2125

Closed
longXboy opened this issue Jun 6, 2018 · 3 comments
Closed

【QA】When to publish a new Release? #2125

longXboy opened this issue Jun 6, 2018 · 3 comments

Comments

@longXboy
Copy link
Contributor

longXboy commented Jun 6, 2018

I want to update my grpc because of the fatal bug #2106 ,but the bazel only support official version https://github.com/bazelbuild/rules_go/blob/master/go/private/repositories.bzl
So When to publish a new Release 1.12.1?

@longXboy longXboy changed the title 【QA】When to publish a new version? 【QA】When to publish a new Release? Jun 6, 2018
@menghanl
Copy link
Contributor

menghanl commented Jun 6, 2018

Can you double check it's #2106? Why is that important for you?

The original plan is to not include it in the minor release. But if you really need it, we can add it.

@longXboy
Copy link
Contributor Author

longXboy commented Jun 7, 2018

@menghanl Thanks for your reply!
My project crashed three times because of this unsafe datarace bug.
However, I now find that I can just delete this configuration ServerParameters.MaxConnectionAge to solve this problem.

@longXboy longXboy closed this as completed Jun 7, 2018
@menghanl
Copy link
Contributor

menghanl commented Jun 7, 2018

Since you've found a workaround, I will not include #2106 in the next minor release (the reason is to minimize the change in case there are unintentional changes).

If you later find it still bothers you, please reply here.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants