-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godep save
fails on empty grpc_lb_v1 package for grpc 1.6+
#1733
Comments
Was able to resolve this. Once the |
godep issue: tools/godep#554 |
Thanks! I had a feeling that was the problem -- we have no .go files in that path, so the error is accurate; it's just not clear why it would be an error. |
@dfawley If you're willing to merge it, #1743 would be a huge help to kubernetes for getting grpc upgraded. We're currently stuck on 1.3.0. We'd need a new 1.7.x cut with it though.. I was hoping that maybe we could get this fixed in godep, but the project has had no activity since February this year, so I'm doubtful that even if we authored the PR that it would get merged. The only other paths forward are #1743 or to wait till a large number of kubernetes' transitive dependencies are on grpc 1.7.x. |
When upgrading kubernetes from grpc 1.3.0 to 1.7.4,
godep save
reported this error:After locally adding a
doc.go
placeholder file to thegrpc/grpclb/grpc_lb_v1
dir in grpc source, thegodep save
command ran successfully.I'll attempt to create a minimal example that reproduces the issue.
The text was updated successfully, but these errors were encountered: