Better format for error.message in stream

[rinatio]

If you throw an error in stream gRPC API

return status.Error(codes.NotFound, "Foo Bar");

the grpc-gateway translate it this way:

{"error":{"grpc_code":5,"http_code":404,"message":"rpc error: code = NotFound desc = Foo Bar","http_status":"Not Found"}}

Expected result:

{"error":{"grpc_code":5,"http_code":404,"message":"Foo Bar","http_status":"Not Found"}}

Here's a code that might fix it in runtime/handler.go

func streamChunk(result proto.Message, err error) map[string]proto.Message {
	if err != nil {
		grpcCode := codes.Unknown
		message := err.Error()
		if s, ok := status.FromError(err); ok {
			grpcCode = s.Code()
			message = s.Message()
		}
		httpCode := HTTPStatusFromCode(grpcCode)
		return map[string]proto.Message{
			"error": &internal.StreamError{
				GrpcCode:   int32(grpcCode),
				HttpCode:   int32(httpCode),
				Message:    message,
				HttpStatus: http.StatusText(httpCode),
			},
		}
	}
    ...

[achew22]

I think this is going to be handled by #515. Please reopen if you don't htink that's the case.

[rinatio]

@achew22 Thank you for quick reply. I'm not sure it is the same issue. I will double check.