Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) #159

amenk · 2020-02-02T14:53:59Z

Mostly adding Addis Ababa Scripts
Also add transitfeedflex Module to support Minibus System in Addis Ababa

* no schedule * trips copied from gh_accra class

* stop IDs of the format OSM_TYPE/ID are used now * Stations are no longer grouper together (stop hierachies are only to be used for big bus terminals and trams, see https://support.google.com/transitpartners/answer/6377423?hl=en)

… of and pick up)

nlehuby

Nice work @amenk

nlehuby · 2020-02-03T07:31:31Z

osm2gtfs/creators/et_addisababa/config.json

@@ -0,0 +1,35 @@
+{


All config should come with some regression tests, so we can make sure our future changes in osm2gtfs do not break your own implementation.

I will probably not be able to add those from my current limited python skills. Help is appreciated.

nlehuby · 2020-02-03T07:32:29Z

osm2gtfs/creators/et_addisababa/trips_creator_et_addisababa.py

+            elif 'route_master' in line.tags and line.tags['route_master'] == "share_taxi":
+                route_type = "Bus"
+                route_suffix = " (Minibus)"
+                flex_flag = 0


if flex_flag is a flag, can we use a Boolean ?

Probably yes :-)

nlehuby · 2020-02-03T07:34:45Z

osm2gtfs/creators/et_addisababa/trips_creator_et_addisababa.py

+            elif 'route_master' in line.tags and line.tags['route_master'] == "share_taxi":
+                route_type = "Bus"
+                route_suffix = " (Minibus)"
+                flex_flag = 0


I don't like the idea of it being hard-coded. Can we rather have that information as an attribute on the route / route_master in OSM ?

Possible, need to discuss with the OSM community how it is mapped best on OSM side.

nlehuby · 2020-02-03T07:35:10Z

osm2gtfs/creators/et_addisababa/trips_creator_et_addisababa.py

+
+            flex_flag = None
+            if 'route_master' in line.tags and line.tags['route_master'] == "light_rail":
+                route_type = "Tram"


I don't understand why you need to override the route_type here 🤔

In OSM we tagged it as light_rail, and I was thinking it needs to be mapped to Tram in GTFS; but I am not sure

nlehuby · 2020-02-03T07:37:02Z

transitfeedflex/README

@@ -0,0 +1 @@
+Adds Flexible Pick Off / Drop Off (Part of the GTFSFlex specification)


👍 That's really cool to add this feature!

Can you please add a link to the documentation of the format ?

long time no feedback, sorry :-)
I think it is described here: https://github.com/MobilityData/gtfs-flex/blob/master/spec/reference.md

nlehuby · 2020-02-03T07:39:05Z

osm2gtfs/creators/et_addisababa/trips_creator_et_addisababa.py

+                trip_gtfs.AddFrequency(
+                    "05:00:00", "22:00:00", ROUTE_FREQUENCY * 60)
+
+                if 'duration' in a_route.tags:


the ci_abidjan creator also use duration and interval tags for the same purpose 🤔 I wonder if / how we can mutualize the implementations to avoid code duplication.

Interesting, how could we do this?

amenk · 2022-10-22T08:44:25Z

Long time no see - sorry, I was kind of pushed back by the requirements for regression tests and also we did not work for some while on the project.

We want to bring this pull request forward :-) Unfortunately I have to confess that I only limited Python skills, so might need some support. But we will try our best to get this ready for merge.

amenk · 2022-10-22T12:29:04Z

Actually I am nowadays no longer sure if OpenTripplanner v2 (which we use for routing) supports those continuous_pickup + continuous_drop_off fields.

It's also not really documented any more in the spec.

Ref: MobilityData/gtfs-flex#70
opentripplanner/OpenTripPlanner#2603

derhuerst · 2022-10-24T11:39:35Z

Actually I am nowadays no longer sure if OpenTripplanner v2 (which we use for routing) supports those continuous_pickup + continuous_drop_off fields.

For better discoverability, this is Leonard's reply on the OTP mailing list:

continuous_pickup/dropoff is currently not supported by OTP2.
There is however an open PR that would need some polishing to get merged: opentripplanner/OpenTripPlanner#3457
Several people have expressed interest in taking over from the original author but so far no-one has stepped forward.

(Sorry if this is irrelevant, I'm a random lurker on this Issue.)

hannesj · 2022-10-25T16:38:09Z

It's also not really documented any more in the spec.

It is part of the main GTFS specification https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#stop_timestxt

amenk and others added 17 commits December 8, 2019 19:38

First version of Addis Ababa generator

3d2fb3f

* no schedule * trips copied from gh_accra class

Add osm_type to the stop_id

0220d8d

Agency Info; extend bounds of Addis Ababa a bit

68164d4

Mostly copy stop generator from Ghana

8ad2de6

Reset Addis Ababa Scripts (copy from gh_accra)

223fb80

Add different config files for Anbessa / Sheger

7caa135

Use "duration" tag for interpolation trip timings

e923038

Show warning if default travel time (duration) is used

f92bfc9

ignore .vscode

090e03d

Generate frequencies.txt from inverval tags in routes

5909a8a

Add light rail to the feed

1dd9d17

Remove custom stops creator / use standard stop IDs

54b5806

* stop IDs of the format OSM_TYPE/ID are used now * Stations are no longer grouper together (stop hierachies are only to be used for big bus terminals and trams, see https://support.google.com/transitpartners/answer/6377423?hl=en)

Add share taxi (minibus) to known route types

3eefdcd

Rename Light rail from Tram in known types

8f86d82

WIP: Flex support

8281870

Finalize Flex-Routes (for Minibus -> set flex_flag for continous drop…

b4bf0b9

… of and pick up)

Merge branch 'master' into develop-flex

8dfb768

amenk mentioned this pull request Feb 2, 2020

Support hail_and_ride / GTFS Flex #156

Open

nlehuby reviewed Feb 3, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into develop-flex

b1f1f0c

amenk changed the title ~~Add Addis Ababa and Add Partial GTFSFlex Impelmentation (#156)~~ Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) Oct 22, 2022

amenk added 3 commits April 3, 2023 12:50

Add minibus data, change expiry data

56a071c

Merge branch 'develop' into develop-flex

390fa50

Always use nodes as ID in Addis Ababa

c092176

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) #159

Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) #159

amenk commented Feb 2, 2020

nlehuby left a comment

nlehuby Feb 3, 2020

amenk Oct 22, 2022

nlehuby Feb 3, 2020

amenk Oct 22, 2022

nlehuby Feb 3, 2020

amenk Oct 22, 2022

nlehuby Feb 3, 2020

amenk Oct 22, 2022

nlehuby Feb 3, 2020

amenk Oct 22, 2022

nlehuby Feb 3, 2020

amenk Oct 22, 2022

amenk commented Oct 22, 2022

amenk commented Oct 22, 2022

derhuerst commented Oct 24, 2022 •

edited

Loading

hannesj commented Oct 25, 2022

		@@ -0,0 +1 @@
		Adds Flexible Pick Off / Drop Off (Part of the GTFSFlex specification)

Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) #159

Are you sure you want to change the base?

Add Addis Ababa and Add Partial GTFSFlex Implementation (#156) #159

Conversation

amenk commented Feb 2, 2020

nlehuby left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amenk commented Oct 22, 2022

amenk commented Oct 22, 2022

derhuerst commented Oct 24, 2022 • edited Loading

hannesj commented Oct 25, 2022

derhuerst commented Oct 24, 2022 •

edited

Loading