Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after :all + around :all #54

Open
grosser opened this issue Jun 24, 2023 · 0 comments
Open

after :all + around :all #54

grosser opened this issue Jun 24, 2023 · 0 comments

Comments

@grosser
Copy link
Owner

grosser commented Jun 24, 2023

for after :all:
we need to track some kind of class hierarchy since a sub-class should not trigger the patent-class to run it's after :all hook

describe a do
  after :all { foo }
  it foo
  # not here
  describe b do
    it bar
    # but here
  end
end

especially with random test (can be disabled) + random class ordering (cannot be disabled without hackery) that will be tricky
also the usefulness is pretty low since there could be lots of tests that don't belong to the class with after :all that are run in between

for around :all:
once after :all works that should be the same fiber hackery like we use for the current around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant