Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon (re)advertisement should not use a new address for change #2326

Closed
div72 opened this issue Sep 10, 2021 · 2 comments · Fixed by #2388
Closed

Beacon (re)advertisement should not use a new address for change #2326

div72 opened this issue Sep 10, 2021 · 2 comments · Fixed by #2388
Assignees
Milestone

Comments

@div72
Copy link
Member

div72 commented Sep 10, 2021

I am omitting the feature request template since the title is self-explanatory.

@jamescowens
Copy link
Member

jamescowens commented Nov 14, 2021

@cyrossignol and @div72... looking at this and CreateContractTx, perhaps we want to generalize the use of coin_control_out to return the change to the input UTXO address in all instances, not just the master key case? This is debatable, but anyone sending contracts is not aiming for anonymity, and generating a new change address on the change complicates backup considerations after sending contracts.

@div72
Copy link
Member Author

div72 commented Nov 15, 2021

but anyone sending contracts is not aiming for anonymity,

I know that the state of message contracts are a bit uncertain at the moment with possible thoughts about them being removed but I personally think that message contracts should not be removed and returning the change back for non-message contracts makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants