Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending PWL Costs #235

Closed
bknueven opened this issue Jun 17, 2021 · 1 comment · Fixed by #237
Closed

Extending PWL Costs #235

bknueven opened this issue Jun 17, 2021 · 1 comment · Fixed by #237
Assignees

Comments

@bknueven
Copy link
Collaborator

bknueven commented Jun 17, 2021

The PWL cost curve handling introduced in #227 fail when the lowest power point on the curve is greater than or equal p_max and when the highest power point on the curve is less than or equal to p_min.

To resolve this, we could either:

  1. Determine this is a user error, in which case we should throw a proper error.
  2. Handle this case automatically. We already extend the PWL cost curve beyond its given bounds, so extending it in this case is perhaps not the worst thing.
@DLWoodruff
Copy link
Collaborator

I need a decision on this issue sooner rather than later. It is a simple question, but I can't honestly say I know what is the right answer. BTW: I think he means "when the lowest power point on the cost curve is greater than p_max " But anyway, the question is: should Egret silently extend the piecewise cost curve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants