Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customer table: c_last_review_date vs c_last_review_date_sk #28

Open
gregrahn opened this issue Mar 23, 2017 · 2 comments
Open

customer table: c_last_review_date vs c_last_review_date_sk #28

gregrahn opened this issue Mar 23, 2017 · 2 comments
Labels
bug

Comments

@gregrahn
Copy link
Owner

The definition of customer in tpcds.sql lists the last column as
c_last_review_date char(10)
however the TPC-DS spec v2.4 list the last column as
c_last_review_date_sk identifier with FK to d_date_sk

The DDL looks incorrect. This column change also impacts query30.tpl
@gregrahn gregrahn added the bug label Mar 23, 2017
@gregrahn
Copy link
Owner Author

gregrahn commented Oct 14, 2017 •
edited
Loading

Fixed in v2.6.0 in query30, but DDL (tpcds.sql) not updated to match in official release.
I've made both the column name and type change in tpcds.sql

@gregrahn gregrahn mentioned this issue Aug 2, 2019
Closed
@gregrahn
Copy link
Owner Author

https://tpcorg.fogbugz.com/default.asp?3037_lq3je9v9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregrahn