Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix #1146 #1168

Merged
merged 4 commits into from
Jun 29, 2016
Merged

attempt to fix #1146 #1168

merged 4 commits into from
Jun 29, 2016

Conversation

eroux
Copy link
Contributor

@eroux eroux commented Jun 28, 2016

fixes #1146

@eroux eroux added this to the 4.2 milestone Jun 28, 2016
@eroux
Copy link
Contributor Author

eroux commented Jun 28, 2016

this is ready to review

@henryso
Copy link
Contributor

henryso commented Jun 29, 2016

The new space should be added to the documentation. Otherwise, I think this looks fine.

@eroux
Copy link
Contributor Author

eroux commented Jun 29, 2016

Thanks, I've documented the introduced spaces, merging...

@eroux eroux merged commit ea5f3e6 into release-4.2 Jun 29, 2016
@henryso henryso deleted the fix-1146 branch June 29, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants