Feature/Allow to display search bar from init #893
Conversation
Merge with source
RafaelloLollipop
changed the title
RafaelloLollipop
force-pushed
the
feature/allow-to-display-search-from-init
branch
from
3541048 to
d192f4c
Compare
|
Bump, I also require this for my use case |
gabrielliwerant
added
the
needs review
|
Bump one more time, this feature is critical to a use case |
README.md
Outdated
| @@ -165,6 +165,7 @@ The component accepts the following props: | |||
| |**`sort`**|boolean|true|Enable/disable sort on all columns | |||
| |**`filter`**|boolean|true|Show/hide filter icon from toolbar | |||
| |**`search`**|boolean|true|Show/hide search icon from toolbar | |||
| |**`showSearch`**|boolean|false|Initially displays search bar | |||
There was a problem hiding this comment.
What do you think about calling the option searchOpen instead? My concern is that I want to distinguish it from the numerous search options that exist now, and I worry it may cause confusion with the option that shows/hides the icon form the toolbar.
There was a problem hiding this comment.
Lets add a line in our PropTypes definition https://github.com/gregnb/mui-datatables/blob/master/src/MUIDataTable.js#L132.
gabrielliwerant
added
needs work
and removed
needs review
|
@VallHer I've made the above changes in a pull request to your fork. |
…m-init rename showSearch to searchOpen. add propType.
|
Ups. I merged above changes but now I see that there was to much things renamed. I will fix it in 1-2h. |
…earch-from-init Revert "rename showSearch to searchOpen. add propType."
…m-init fixed: searchOpen with propType
|
Thanks @AcBerk. Now should be okay:D |
|
Hi. I really appreciate for this amazing table. |
* Add option to display search bar at init * rename showSearch to searchOpen. add propType. * Revert "rename showSearch to searchOpen. add propType." * fixed: searchOpen with propType
* Add option to display search bar at init * rename showSearch to searchOpen. add propType. * Revert "rename showSearch to searchOpen. add propType." * fixed: searchOpen with propType
RafaelloLollipop
deleted the
feature/allow-to-display-search-from-init
branch
Added option to show search from init. (in my case I want to resign from using searchIcon hide/display). In current version it is only possible when searchText is defined, but I want to have placeholder at init.