Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings don't work starting in version 2.14.0 / How to disable deprecation warnings #1319

Closed
patorjk opened this issue Jun 9, 2020 · 0 comments

Comments

@patorjk
Copy link
Collaborator

patorjk commented Jun 9, 2020

This issue is mostly for documentation purposes and for those searching the issues for a way to disable deprecation warnings.

In preparing version 3.0.0, I noticed that the deprecation warnings for deprecated options no longer print to the console. I traced it back to this commit 58df9bc#diff-2b4ca49d4bb0a774c4d4c1672d7aa781. The intent was to disable deprecation warnings in prod mode, but instead it removes deprecation warnings all together. When the library is built for deployment, they're removed. So no user of the library ever sees them (they only appear to developers working with the mui-datatables source code in dev mode).

I've updated the v3 branch to remove the check that was added so that deprecation warnings will once again show up in the console.

If you want to disable these warnings, there is now an undocumented option called "consoleWarnings". Set it to false and the warnings wont' appear. In the future I may look for a better solution to this, however, I want to get v3 out and noticed this while testing out a beta version from npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant