Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of let and with is incorrect within a Gherkin Scenario and ScenarioOutline #126

Open
ashleyfrieze opened this issue Sep 21, 2017 · 3 comments

Comments

@ashleyfrieze
Copy link
Contributor

It appears that let is running for each sub-step, which is not as intended.

I'll rush out a fix when I can find one.

@ashleyfrieze
Copy link
Contributor Author

ashleyfrieze@154695e <- failing tests inserted to demonstrate the issue.

@ashleyfrieze ashleyfrieze changed the title Behaviour of let is incorrect within a Gherkin Scenario Behaviour of let and with is incorrect within a Gherkin Scenario and ScenarioOutline Sep 22, 2017
@ashleyfrieze
Copy link
Contributor Author

There are three issues:

  1. The code for propagating hooks allowed atomic hooks to drop down through a Suite that was itself atomic. You would not expect let to get a fresh answer for each sub-step of a Scenario but you were.
  2. The scenarioOutline was just using describe to create each instance of the Scenario for each example, making it NOT create a composite test, making the above not work, even if it had been working
  3. The application of blockConfiguration was only implemented for describe not for scenario - root cause was some code duplication with the correct answer only in one place.

@greghaskins - I'd like to consider a patch release, which is why I've made the changes on a branch off our last release. We may not be ready for releasing master yet, as I think some more work on timeout would be a good idea. I think we SHOULD release these fixes after you've reviewed them.

@ashleyfrieze
Copy link
Contributor Author

Fixes and tests that illustrate the issues on #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant