Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(borders): add missing types to the borders system utility group #346

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

kamalbennani
Copy link
Contributor

Summary

Hi 👋

I started using your library as a replacement for the "abandoned" styled-system repository and the migration is going well.

That being said, I saw that the borders utility group exposes a lot of props but the typing was not reflecting those available props such as borderTopStyle etc ...

So the goal of this PR is to add the missing typing to the BordersProps interface.

@gregberge gregberge merged commit c0c92b4 into styled-components:main Jan 23, 2022
@kamalbennani kamalbennani deleted the impr/border-typings branch February 6, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants