-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatExportName for single names #548
Fix formatExportName for single names #548
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/gregberge/svgr/6yuQ4C5HwMdcmqUnPuiUg7ghNB2q |
Codecov Report
@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 87.19% 87.32% +0.13%
==========================================
Files 31 31
Lines 570 568 -2
Branches 160 159 -1
==========================================
- Hits 497 496 -1
+ Misses 58 57 -1
Partials 15 15
Continue to review full report at Codecov.
|
@gregberge Thanks for this incredible tool. Can we have an ETA for this fix? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm running into this issue now too. Would it be possible to merge in this PR? |
Sorry, I merged it. I will probably release v6 soon, stay tuned. |
Great news! Thank you, we'll be looking out for v6! |
Summary
This PR fixes the
formatExportName
for single names. For example, for names likefoo
it should exportFoo
name insteadfoo
as named export in index.js file. This will fix the named exports in index.js.Actual output:
Expected output:
The PR is motivated by this issue: #481