Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to opt-out of cosmiconfig #179

Closed
Timer opened this issue Sep 20, 2018 · 3 comments
Closed

Add a way to opt-out of cosmiconfig #179

Timer opened this issue Sep 20, 2018 · 3 comments

Comments

@Timer
Copy link

Timer commented Sep 20, 2018

🚀 Feature Proposal

Create React App uses svgr and we'd like a way to disable the ability to configure the tool via any/all means (mostly via cosmiconfig).
Configuration was not present in v1 and is preventing us from moving to v2. 😄

Motivation

Create React App likes to provide sensible defaults that just work, never requiring the user gain an understanding of what lies underneath.

Example

Add an option to the webpack loader / related packages to disable cosmiconfig for svgr & svgo, relying only on the options provided via the API.

@TrySound
Copy link
Contributor

I can't find a place where webpack loader uses external config. Are you sure this feature exists?
https://github.com/smooth-code/svgr/blob/master/packages/webpack/src/index.js
https://github.com/smooth-code/svgr/blob/master/packages/core/src/convert.js

@gregberge
Copy link
Owner

Follow up #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants