feat(pr): add license and publisher info to pr text

greenkeeperio · Jul 4, 2019 · a98e709 · a98e709
1 parent 1ee49fc
commit a98e709
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 6 deletions.
diff --git a/content/update-pr.js b/content/update-pr.js
@@ -1,7 +1,9 @@
 const _ = require('lodash')
 const md = require('./template')
 
-module.exports = ({ version, dependencyLink, dependency, monorepoGroupName, release, diffCommits, oldVersionResolved, type, packageUpdateList }) => {
+module.exports = ({
+  version, dependencyLink, dependency, monorepoGroupName, release, diffCommits, oldVersionResolved, type, packageUpdateList, license, licenseHasChanged, publisher
+}) => {
   const hasReleaseInfo = release && diffCommits
   return md`
 ${monorepoGroupName
@@ -15,6 +17,11 @@ ${monorepoGroupName && `\nThis monorepo update includes releases of one or more
 }
 ---
 
+publisher: ${publisher}
+${licenseHasChanged ? `License has changed from the prevoius release.` : ''}
+license: ${license}
+
+---
 ${hasReleaseInfo
     ? _.compact([release, diffCommits])
     : `[Find out more about this release](${dependencyLink}).`

diff --git a/jobs/create-group-version-branch.js b/jobs/create-group-version-branch.js
@@ -360,6 +360,11 @@ module.exports = async function (
     prTitles: config.prTitles })
 
   const dependencyLink = getFormattedDependencyURL({ repositoryURL: transforms[0].repoURL })
+
+  const license = versions[version].license
+  const licenseHasChanged = versions[oldVersionResolved].license !== license
+  const publisher = versions[version]['_npmUser'].name
+
   // maybe adapt PR body
   const body = prContent({
     dependencyLink,
@@ -370,7 +375,10 @@ module.exports = async function (
     type: highestPriorityDependency,
     release,
     diffCommits,
-    packageUpdateList
+    packageUpdateList,
+    license,
+    licenseHasChanged,
+    publisher
   })
 
   // verify pull requests commit

diff --git a/jobs/create-version-branch.js b/jobs/create-version-branch.js
@@ -34,7 +34,7 @@ module.exports = async function (
     accountId,
     repositoryId,
     type,
-    // The following 4 don’t matter anymore, since we fetch them anew for every dependency anyway
+    // The following 4 don’t matter anymore, sincversionse we fetch them anew for every dependency anyway
     version,
     oldVersion,
     oldVersionResolved,
@@ -336,6 +336,10 @@ module.exports = async function (
     dependency: dependencyKey,
     prTitles: config.prTitles })
 
+  const license = versions[version].license
+  const licenseHasChanged = versions[oldVersionResolved].license !== license
+  const publisher = versions[version]['_npmUser'].name
+
   const body = prContent({
     dependencyLink,
     oldVersionResolved,
@@ -345,7 +349,10 @@ module.exports = async function (
     diffCommits,
     monorepoGroupName,
     type,
-    packageUpdateList
+    packageUpdateList,
+    license,
+    licenseHasChanged,
+    publisher
   })
 
   // verify pull requests commit

diff --git a/test/jobs/create-version-branch.js b/test/jobs/create-version-branch.js
@@ -268,8 +268,28 @@ describe('create version branch', () => {
       oldVersion: '^1.0.0',
       oldVersionResolved: '1.0.0',
       versions: {
-        '1.0.0': {},
-        '2.0.0': {}
+        '1.0.0': {
+          'repository': {
+            type: 'git',
+            url: 'git+https://github.com/lodash/lodash.git'
+          },
+          'license': 'MIT',
+          '_npmUser': {
+            name: 'jdalton',
+            email: '[email protected]'
+          }
+        },
+        '2.0.0': {
+          'repository': {
+            type: 'git',
+            url: 'git+https://github.com/lodash/lodash.git'
+          },
+          'license': 'TIM',
+          '_npmUser': {
+            name: 'jdalton',
+            email: '[email protected]'
+          }
+        }
       }
     })