reafctor(tests): extract removeIfExists function to helper file

greenkeeperio · Oct 2, 2017 · 96778af · 96778af
1 parent 8c98d44
commit 96778af
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 40 deletions.
diff --git a/test/jobs/github-event/marketplace_purchase/cancelled.js b/test/jobs/github-event/marketplace_purchase/cancelled.js
@@ -1,16 +1,7 @@
 const { test, tearDown } = require('tap')
 const dbs = require('../../../../lib/dbs')
 const worker = require('../../../../jobs/github-event/marketplace_purchase/cancelled')
-
-const removeIfExists = async (db, id) => {
-  try {
-    return await db.remove(await db.get(id))
-  } catch (e) {
-    if (e.status !== 404) {
-      throw e
-    }
-  }
-}
+const removeIfExists = require('../../../remove-if-exists.js')
 
 test('marketplace canceled', async t => {
   t.test('change entry in payments database to `free`', async t => {

diff --git a/test/jobs/github-event/marketplace_purchase/changed.js b/test/jobs/github-event/marketplace_purchase/changed.js
@@ -1,16 +1,7 @@
 const { test, tearDown } = require('tap')
 const dbs = require('../../../../lib/dbs')
 const worker = require('../../../../jobs/github-event/marketplace_purchase/changed')
-
-const removeIfExists = async (db, id) => {
-  try {
-    return await db.remove(await db.get(id))
-  } catch (e) {
-    if (e.status !== 404) {
-      throw e
-    }
-  }
-}
+const removeIfExists = require('../../../remove-if-exists.js')
 
 test('marketplace changed', async t => {
   t.test('change entry in payments database', async t => {

diff --git a/test/jobs/github-event/marketplace_purchase/purchased.js b/test/jobs/github-event/marketplace_purchase/purchased.js
@@ -2,16 +2,7 @@ const { test, tearDown } = require('tap')
 const nock = require('nock')
 const dbs = require('../../../../lib/dbs')
 const worker = require('../../../../jobs/github-event/marketplace_purchase/purchased')
-
-const removeIfExists = async (db, id) => {
-  try {
-    return await db.remove(await db.get(id))
-  } catch (e) {
-    if (e.status !== 404) {
-      throw e
-    }
-  }
-}
+const removeIfExists = require('../../../remove-if-exists.js')
 
 nock.disableNetConnect()
 nock.enableNetConnect('localhost')

diff --git a/test/jobs/reset.js b/test/jobs/reset.js
@@ -1,6 +1,7 @@
 const { test } = require('tap')
 const nock = require('nock')
 const worker = require('../../jobs/reset')
+const removeIfExists = require('../remove-if-exists.js')
 
 const dbs = require('../../lib/dbs')
 const timeToWaitAfterTests = 500
@@ -11,16 +12,6 @@ const waitFor = (milliseconds) => {
   })
 }
 
-const removeIfExists = async (db, id) => {
-  try {
-    return await db.remove(await db.get(id))
-  } catch (e) {
-    if (e.status !== 404) {
-      throw e
-    }
-  }
-}
-
 nock.disableNetConnect()
 nock.enableNetConnect('localhost')
 

diff --git a/test/remove-if-exists.js b/test/remove-if-exists.js
@@ -0,0 +1,9 @@
+module.exports = async function (db, id) {
+  try {
+    return await db.remove(await db.get(id))
+  } catch (e) {
+    if (e.status !== 404) {
+      throw e
+    }
+  }
+}