refactor: don't check for payment when PR is opened and repo is public

greenkeeperio · Jan 24, 2018 · 73799d1 · 73799d1
1 parent cac2e7a
commit 73799d1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/jobs/github-event/pull_request/opened.js b/jobs/github-event/pull_request/opened.js
@@ -35,13 +35,18 @@ module.exports = async function (data) {
       createdByUser: true
     }
   )
+
+  if (!repoDoc.private) {
+    return
+  }
+
   const ghqueue = githubQueue(installation.id)
 
   const billingAccount = await getActiveBilling(accountId)
   const hasBillingAccount = !!billingAccount
   const accountNeedsMarketplaceUpgrade = await getAccountNeedsMarketplaceUpgrade(accountId)
 
-  if (repoDoc.private && ((!hasBillingAccount || accountNeedsMarketplaceUpgrade))) {
+  if (!hasBillingAccount || accountNeedsMarketplaceUpgrade) {
     const targetUrl = accountNeedsMarketplaceUpgrade ? 'https://github.com/marketplace/greenkeeper/' : 'https://account.greenkeeper.io/'
 
     await ghqueue.write(github => github.repos.createStatus({