Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename correctBuild to updateBuild #168

Open
patkub opened this issue Jun 22, 2018 · 0 comments
Open

Rename correctBuild to updateBuild #168

patkub opened this issue Jun 22, 2018 · 0 comments

Comments

@patkub
Copy link
Contributor

patkub commented Jun 22, 2018 •
edited
Loading

Right now, update.js checks correctBuild before running, and upload.js checks uploadBuild. Would it make more sense to rename correctBuild to updateBuild and know that updateBuild is checked in update.js?

This way CI enviornment checks for greenkeeper-lockfile-update would go in updateBuild, and checks for greenkeeper-lockfile-upload would go in uploadBuild.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patkub