Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: New marking of deprecated data objects #3907

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

timopollmeier
Copy link
Member

What

Data objects like configs, port lists and report formats that are deprecated are marked as such on the list and details pages as well as in dialog dropdowns.

Why

To make the deprecation visible to users.

References

GEA-6

Checklist

  • Tests

@timopollmeier timopollmeier requested a review from a team as a code owner October 31, 2023 11:35
@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3907 (057b507) into main (c259f28) will increase coverage by 0.00%.
The diff coverage is 64.28%.

❗ Current head 057b507 differs from pull request most recent head ec67092. Consider uploading reports for the commit ec67092 to get more accurate results

@@           Coverage Diff           @@
##             main    #3907   +/-   ##
=======================================
  Coverage   59.95%   59.95%           
=======================================
  Files        1022     1022           
  Lines       25125    25144   +19     
  Branches     7443     7448    +5     
=======================================
+ Hits        15063    15075   +12     
- Misses       9114     9121    +7     
  Partials      948      948           
Files Coverage Δ
src/web/pages/scanconfigs/details.js 100.00% <100.00%> (ø)
src/web/utils/render.js 22.91% <100.00%> (+0.92%) ⬆️
src/web/entities/entitynametabledata.js 72.72% <50.00%> (-5.06%) ⬇️
src/web/pages/portlists/details.js 18.18% <0.00%> (-4.05%) ⬇️
src/web/pages/reportformats/details.js 15.38% <0.00%> (-2.80%) ⬇️

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Data objects like configs, port lists and report formats that are
deprecated are marked as such on the list and details pages as well as
in dialog dropdowns.
@a-h-abdelsalam a-h-abdelsalam merged commit 161cc7b into main Nov 6, 2023
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the mark-deprecated-data-objects branch November 6, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants