Show xref type in NVT details #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
added
port-to-main
sarahd93
approved these changes
Jun 10, 2021
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2980 +/- ##
==========================================
Coverage 53.74% 53.74%
==========================================
Files 1072 1072
Lines 25909 25912 +3
Branches 7400 7403 +3
==========================================
+ Hits 13924 13926 +2
- Misses 10881 10882 +1
Partials 1104 1104
Continue to review full report at Codecov.
|
This was referenced Jun 15, 2021
swaterkamp
added a commit
that referenced
this pull request
Jun 15, 2021
Show xref type in NVT details (backport #2980)
swaterkamp
added a commit
that referenced
this pull request
Jun 16, 2021
Show xref type in NVT details (backport #2980)
swaterkamp
added a commit
that referenced
this pull request
Jun 16, 2021
Show xref type in NVT details (backport #2980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Show the type of xrefs in the reference section of NVTs, except url.
Why:
There seemed to be changes made in the NASL scripts that altered the content of
nameandtypeof xrefs.NOTE: It is not 100% clear how the change of behavior happened but GSA is already getting the type in lower case only, therefore it will appear as that in the details as well..
How:
Visually check whether the type is included.
Checklist: