Drop gmp scanner type from GSA #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2498 +/- ##
=============================================
+ Coverage 52.93% 53.08% +0.14%
=============================================
Files 1070 1071 +1
Lines 25811 25845 +34
Branches 7351 7375 +24
=============================================
+ Hits 13664 13720 +56
+ Misses 11030 11008 -22
Partials 1117 1117
Continue to review full report at Codecov.
|
saberlynx
force-pushed
the
drop-gmp-scanner-2
branch
from
1cf3047
to
609418b
Compare
sarahd93
reviewed
Oct 12, 2020
bjoernricks
reviewed
Oct 12, 2020
bjoernricks
reviewed
Oct 12, 2020
| @@ -109,14 +109,15 @@ const Row = ({ | |||
| {entity.alterable === 1 && ( | |||
| <AlterableIcon size="small" title={_('Audit is alterable')} /> | |||
| )} | |||
| {isDefined(scanner) && scanner.scannerType === GMP_SCANNER_TYPE && ( | |||
There was a problem hiding this comment.
Oh I think this is wrong in 20.08 already and should include the GREENBONE_SENSOR_TYPE in that version too.
There was a problem hiding this comment.
Yeah, we forgot to update the audit row when we added the greenbone sensor type
bjoernricks
reviewed
Oct 12, 2020
bjoernricks
reviewed
Oct 12, 2020
bjoernricks
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Drops GMP_SCANNER_TYPE everywhere in GSA.
Why:
How:
Tests are adjusted accordingly and should pass.
Checklist: