[REQUEST FOR COMMENT] Community Takeover (Fork) 9/18

[PatrickDesign]

Summary
There have been many attempts to pass on the ownership of this package to new maintainers as seen in our own README as well as (#247). There have also been calls for a community takeover on r/react. All of these requests for assistance have been met with people who are readily available to help maintain the project.

Describe the solution you'd like
With cooperation from the community, I propose that if we do not hear back from @greena13 by Friday, September 18th (2020), we perform a community takeover by forking the project. We can then start making headway on the current open PRs and issues. I also propose that we come up with a new name for the npm registry together. I was thinking react-keyboard-shortcuts but that's already taken.

Additional context
Attempts to contact the author via LinkedIn & Twitter have been made, but have so far been unsuccessful.

[greena13]

Hi @PatrickDesign,

Thanks for your eye-catching subject line. It saved me from missing this.

No community takeover is necessary. I'm in full agreeance this package needs new ownership. I don't currently have time to even keep a particularly close eye on the issues being filed (which is why I've struggled to sync up any previous offer to take ownership).

If one or more individuals are willing to take responsibility for react-hotkeys and are able to demonstrate the capacity and ability to do so, I'm happy to share or transfer ownership.

[PatrickDesign]

🎉 This is great news! (and obviously less work..)

I am in contact with a few people who are interested in joining me in maintaining the project. Hopefully they jump in this thread :).

[greena13]

That is equally encouraging.

Out of curiosity - I have obviously lost touch - what do you see being the low hanging fruit and areas of primary concern? What would a short-term roadmap look like in your mind?

I'm aware there is a lot to go through and triage in the issues.

[PatrickDesign]

I was thinking something like this 💭

Short term roadmap (essential bugfixes which will hopefully restore all core functionality):

• alt modifier fix [BUG] key mapping with alt+... doesn't work because alt changes keyboard keys #269
• capslock fix [BUG] Simple keybindings don't work with capslock on #225
• "Left over character" fix [BUG] Key combinations such as [ "d d" ] seem to store the 2nd "d" so next time you press "d" it first the ["d d"] combination #279
• autofocus and rerender fixes (seems like a key problem) [BUG] Autofocus input + simple up/down arrow key works only once #285 and keybindings break on re-render #209

Low hanging:

• IE compatibility: [BUG] Internet Explorer 11 broken because use of Object.values #261
• Server-side rendering: Allow compatibility with NodeJS environments without a window #206 (OPEN PR)
• Type fixes: 🐛 Fix incorrect keyboard event type #258 (OPEN PR)
• Layout: [BUG] HotKeys component changes childrens size #265

Requested features that should be implemented as soon as they can be worked on:

• i18n!! [BUG] Hotkeys work only with English language is active #283
• Hooks - nice-to-have Plans for a useHotkeys hook? #210

[greena13]

Sounds sensible to me. 👍

I've added you as a contributor. I'll figure out the next steps, when you have something you think is in a state to release.

Let me know if I can be of any further help.

[Harjot1Singh]

I would put in some PRs if someone was actively merging/maintaining, so do ping this thread whenever this is the case @PatrickDesign.

[wilsongp]

I'd also like to contribute when activity spins back up! I'll poke around the high-priority bugs in the meantime.

[nopol10]

Not sure if I should start a new issue but is there any chance for the the highest priority item to be to update the package published in npm to match the latest commit in this repository? I have encountered a major bug in 2.0.0 (pressing spacebar stops all hotkeys from functioning until a refocus) that does not occur if I build and use the one in this repo.

[ibash]

Forked: https://github.com/ibash/react-hotkeys
Publishing under "react-hotkeys-ce". (ce is for community edition)
I just published the master branch as v2.0.1

If anyone wants to submit pull requests or be a collaborator, just ping me and I'll add you. Feel free to email me to: [email protected]

[ibash]

I'm publishing fixes: https://github.com/ibash/react-hotkeys

[R4VANG3R]

Any update on the "takeover"? I see there's a fork now, but what's the status from the new Ownership?

[ibash]

Submit a pr and I’ll merge it, but I’m not actively using react-hotkeys

[CAMAINElie]

Hi here,

I am currently using this library and would need a few fixes, I am willing to do them myself but would like to know first if it would be used/merged !
Is there still someone in charge here ?

[ibash]

Is there still someone in charge here ?

No, not really.

I'm happy to take PRs on my fork and publish them. (https://github.com/ibash/react-hotkeys) and/or just add you as a maintainer there, but I'm not actively using the library, so not actively fixing bugs.

More recently I've been using tinykeys which is pretty nice: https://github.com/jamiebuilds/tinykeys