Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/only show applied filters #124

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Bugfix/only show applied filters #124

merged 5 commits into from
Oct 13, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Oct 8, 2024 •
edited
Loading

Close #107

@doriengr doriengr self-assigned this Oct 8, 2024
@doriengr doriengr added the need-reviewer Send notification in Discord label Oct 8, 2024
choffmann
choffmann requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter button looks fine now, but when I open the filter, select something and close it without applying or resetting it, the buttons are still active

ge_filter_choose_active

@doriengr doriengr requested a review from choffmann October 12, 2024 10:01
@doriengr doriengr merged commit 644323b into develop Oct 13, 2024
1 check passed
@doriengr doriengr deleted the bugfix/only-show-applied-filters branch October 13, 2024 06:22
@doriengr
Copy link
Contributor Author

@choffmann I know, I did something illegal by already merging it, but I need those changes for my current issue. Maybe you can test it again and we will open a new PR if something is still not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann Awaiting requested review from choffmann

Assignees

@doriengr doriengr

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select a filter and cancel/close the modal without setting the filter, the filter will be shown as active
2 participants
@doriengr @choffmann