Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for RAPL filtering if we use the rapl provider #977

Closed
ribalba opened this issue Nov 12, 2024 · 2 comments · Fixed by #979
Closed

Only check for RAPL filtering if we use the rapl provider #977

ribalba opened this issue Nov 12, 2024 · 2 comments · Fixed by #979

Comments

@ribalba
Copy link
Member

ribalba commented Nov 12, 2024

Currently we always check if rapl filtering is active

def check_energy_filtering():
    if platform.system() != 'Linux':
        print(TerminalColors.WARNING, '>>>> RAPL could not be checked as not running on Linux platform <<<<', TerminalColors.ENDC)
        return True

    result = subprocess.run(['sudo', 'python3', '-m', 'lib.hardware_info_root', '--read-rapl-energy-filtering'],
                            stdout=subprocess.PIPE,
                            stderr=subprocess.PIPE,
                            cwd=os.path.abspath(os.path.join(CURRENT_DIR, '..')),
                            check=True, encoding='UTF-8')
    return "1" != result.stdout.strip()

We should only do this if we are actually going to use the rapl metrics provider. As this is an ERROR check it will fail running GMT even if you are not using RAPL

@ArneTR
Copy link
Member

ArneTR commented Nov 13, 2024

@ArneTR ArneTR linked a pull request Nov 13, 2024 that will close this issue
@ribalba
Copy link
Member Author

ribalba commented Nov 19, 2024

perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants