Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose parameter pause-after-phase #54

Open
davidkopp opened this issue Nov 30, 2023 · 1 comment
Open

Compose parameter pause-after-phase #54

davidkopp opened this issue Nov 30, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@davidkopp
Copy link
Contributor

There is a compose parameter pause-after-phase, but it is not documented and there is no example available.
For which scenarios was this implemented? Is this a parameter that should be used by users of GMT?

It was introduced with the following commit by @ribalba :
green-coding-solutions/green-metrics-tool@4c89f26

@ArneTR
Copy link
Member

ArneTR commented Dec 1, 2023

The parameter in the usage_scenario is currently undocumented as we needed it for an internal feature and it is not well tested.

The case was that we had a container that was doing some preparation work and cache warming in the installation and boot phase. After that it should not be be lingering around anymore.

Since the GMT expects all containers to be present from start to end and fails if the suddenly disappear this parameter allows for a container to bail out after a defined phase.

This needs a documentation and a test case. If you want to use the parameter in your current tests you can use it. It should work as intended, but we cannot provide a test guarantee for it atm.

Thanks for bringing this up. Leaving the Issue open as help wanted. If more people comment we will prioritize this issue.

@ArneTR ArneTR added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants