JavaScript plugin #67
Conversation
There was a problem hiding this comment.
Hi @utarwyn,
I'm ok.
As I understand, you developed the systme that you explained in our weekly appoitment a few weeks ago. Am I rigth ?
I noticed that, you didn't modify the docker-compose file with your new plugin. Is it wanted ?
for me and to have a complete local development environment, we need to have javascript-plugin installed with docker-compose.
|
Yes this implementation is the result of what I described few weeks ago during a weekly meeting. I’d be happy to give you a demonstration of how it works with a test project. Besides, I could push a JavaScript test project (like what you did for Java). oops sorry I forgot to modify the docker-compose.yml, I will work on that this evening. |
|
Kudos, SonarCloud Quality Gate passed! |
javascript-plugin/pom.xml
Outdated
| <artifactId>sonar-packaging-maven-plugin</artifactId> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <pluginKey>${project.artifactId}</pluginKey> |
There was a problem hiding this comment.
Hi @utarwyn , please make the same modifications as https://github.com/green-code-initiative/ecoCode/pull/73/files
This plugin does not contain rule-based analysis, as it is not possible to use AST with JavaScript. It only allows to reference the rules driven by the ESLint plugin of ecoCode-linter. The plugin works in the same way as SonarJS. I plan to develop a tool to import the rules written in the linter to the
rules.jsonfile of the plugin, it will avoid typo and simplify the process to add a rule.Note that in this first version, the rules are not referenced in SonarQube directly because they are considered as external. But they do appear in the interface during an analysis, with the detail:
If you have any ideas to improve the implementation, I'm interested 🤞
Useful links to understand this PR: