Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grsp0008 php #6

Closed
wants to merge 11 commits into from
Closed

Grsp0008 php #6

wants to merge 11 commits into from

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Dec 5, 2022

initial PR (before migration): cnumr/ecoCode#110
(plop @mouradmamassi )

@dedece35 dedece35 added 🚀 enhancement New feature or request 🗃️ rule rule improvment or rule development or bug php labels Dec 5, 2022
# Conflicts:
#	.gitignore
#	php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java
#	php-plugin/src/main/java/fr/cnumr/php/checks/AvoidRelativePathCheck.java
#	php-plugin/src/main/resources/fr/cnumr/l10n/php/rules/custom/GRSP0008.html
#	php-plugin/src/main/resources/fr/cnumr/l10n/php/rules/custom/GRSP0008.json
#	php-plugin/src/test/java/fr/cnumr/php/checks/AvoidRelativePathCheckTest.java
#	php-plugin/src/test/resources/checks/avoidRelativePath.php
@dedece35
Copy link
Member Author

dedece35 commented Jan 7, 2023

Hi @mouradmamassi (and @oussamaLaribi ),
please correct the conflicts

@dedece35 dedece35 marked this pull request as draft January 16, 2023 21:06
@oussamaLaribi oussamaLaribi mentioned this pull request Jan 17, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 23, 2023
@dedece35
Copy link
Member Author

dedece35 commented Feb 2, 2024

Hi @mouradmamassi and @oussamaLaribi,

after discussion with a PHP expert (20 years) in my society, this rule isn't so simple because :

  • implementation is too simple
  • absolute paths usage is a good practice but we can use "DIR" variable to construct absolute path, thus current implementation rule doesn't deal with this use case

Another point, we have to measure this rule to prove the environment impact (maybe on CPU metric).

For the moment, this PR is closed but marked on RULES.md to come back on it to be reworked

@dedece35 dedece35 closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug php 🚀 enhancement New feature or request stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants