[EC82] Variable can be made constant #285
Conversation
| @@ -57,6 +57,7 @@ Some are applicable for different technologies. | |||
| | EC78 | Const parameter in batch update | Don't set const parameter in batch update => Put its in query. Creating this parameter and destroying it consumes CPU cycles and RAM unnecessarily. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC79 | Free resources | try-with-resources Statement needs to be implemented for any object that implements the AutoCloseable interface, it save computer resources. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC81 | Specify struct layouts | When possible, specify struct layouts to optimize their memory footprint | | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | ✅ | | |||
| | EC82 | Make variable constant | A variable is never reassigned and can be made constant. | | 🚀 | 🚀 | 🚀 | 🚀 | 🚀 | ✅ | | |||
There was a problem hiding this comment.
it looks like you added rockets 🚀 to the EC203 rule (that was 🚫 everywhere before)
And on the new rule EC82, everything is 🚫 excepted the last column.
Is it normal ?
There was a problem hiding this comment.
never mind, i think the review screen make me confuse. after checking, it seems good
There was a problem hiding this comment.
when you put 🚀 in all columns mean that this rule can be implemented in all languages. It is possible to implement it in all others languages than c# ?
There was a problem hiding this comment.
EC203 is unchanged, on line 61 now.
EC82 has 🚀 everywhere because it should be applicable in every language, except for C# that has ✅ because the code is ready, just waiting for this PR validation first.
| @@ -57,6 +57,7 @@ Some are applicable for different technologies. | |||
| | EC78 | Const parameter in batch update | Don't set const parameter in batch update => Put its in query. Creating this parameter and destroying it consumes CPU cycles and RAM unnecessarily. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC79 | Free resources | try-with-resources Statement needs to be implemented for any object that implements the AutoCloseable interface, it save computer resources. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC81 | Specify struct layouts | When possible, specify struct layouts to optimize their memory footprint | | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | ✅ | | |||
| | EC82 | Make variable constant | A variable is never reassigned and can be made constant. | | 🚀 | 🚀 | 🚀 | 🚀 | 🚀 | ✅ | | |||
There was a problem hiding this comment.
never mind, i think the review screen make me confuse. after checking, it seems good
| @@ -57,6 +57,7 @@ Some are applicable for different technologies. | |||
| | EC78 | Const parameter in batch update | Don't set const parameter in batch update => Put its in query. Creating this parameter and destroying it consumes CPU cycles and RAM unnecessarily. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC79 | Free resources | try-with-resources Statement needs to be implemented for any object that implements the AutoCloseable interface, it save computer resources. | | ✅ | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | | |||
| | EC81 | Specify struct layouts | When possible, specify struct layouts to optimize their memory footprint | | 🚫 | 🚫 | 🚫 | 🚫 | 🚫 | ✅ | | |||
| | EC82 | Make variable constant | A variable is never reassigned and can be made constant. | | 🚀 | 🚀 | 🚀 | 🚀 | 🚀 | ✅ | | |||
There was a problem hiding this comment.
when you put 🚀 in all columns mean that this rule can be implemented in all languages. It is possible to implement it in all others languages than c# ?
Variable is never reassigned and can be made constant.