[EC34][Java][5R] - Rules "try..catch.."

[Silicoman]

Issue #101

Pour partage avec autre équipe

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

100.0% Coverage
0.0% Duplication

[wokier]

This rule will create too many warning
other way using existing rule: green-code-initiative/creedengo-common#15

[Silicoman]

@Ella-dee , be inform about your work. :) As we discuss on team meeting, it's difficult without details rules. It will generate too many warnings false-positive without more restricted implementation.

[utarwyn]

Based on previous comments and recent work made on custom tags, is this PR still relevant?

I am also afraid of the number of warnings that this rule will cause: we are clearly on a language-based rule and not a platform one. And I am not sure that the impact is that significant compared to the constraints it will bring. What do you think of this?

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

waiting for discussion inside core-team with issue #173

[dedece35]

Hi @Silicoman
please resolve conflict and then check DoD list here https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr

[glalloue]

This rule test only "try" existence and does not give a lot of "intelligence" in the test.
It will return a lot of warnings not really related to eco-conception problems

We suggest to delete this rule and create more specific rules related to try catch (example : add try catch when you create a document to return an error if document does not exists, but prefer test if the document exists before)

Seen with @dedece35 and @jhertout

[dedece35]

TODOs for me :

• replace rule with specific example with FileNotFoundException
  • ecocode-rules-specifications implementation + RULES.md doc
    • [PR 128-ecocode] replace EC34 by EC35 : update CHANGELOG, update rule… #236
  • Python : existing implementation
    • EC34 replaced by EC35 : python implementation creedengo-python#6
    • EC34 replaced by EC35 : test python implementation creedengo-python-test-project#7
  • PHP : existing implementation
    • EC34 replaced by EC35 : PHP implementation  creedengo-php#10
    • [PR 128-ecocode] replace EC34 by EC35 : real test creedengo-php-test-project#5
  • Java : new implementation ==> to discuss because for me not appliable to Java language because all exceptions must be catch even if there is a condition to protect before
    • [EC34][Java][5R] - Rules "try..catch.." #128
• check other issues on the same subject
  • PHP : [EC34] [PHP] raises issues on try-catch blocks without the finally clause #173
  • PHP : [EC34] rework rule creedengo-php#8
  • EC34 [PHP] : rework rule #115

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

After all discussions on this EC34 rule for Java , python and PHP, here are conclusions :

• Python : like described above, EC34 was deprecated and transformed to EC35 with more specific checks
• PHP : same as Python, check above
• Java : neither EC34 rule isn't applicable nor EC35. For this one, file open process must be try-catch even if an exist control of file is done before try

thus, sorry @Silicoman, but I have to refused this PR for Java and close the referenced issue.