[EC34] [PHP] raises issues on try-catch blocks without the finally clause

[jycr]

From @ganncamp (see: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/15):

ecocode-php:EC34’s title is “Avoid using try-catch-finally”, but it raises issues on try-catch blocks without the finally clause. The code sample clears it up, but it seems the rule is really “Avoid using try-catch” or perhaps “Avoid using try-catch and try-catch-finally”?

Ditto Python.

[dedece35]

Hi @jycr, (@glalloue, @mdubois81 , @jules-delecour-dav)

after investigation, for me this rule EC34 is not valid because :

• the issue description isn't accurate
• the rule only checks existence of try statement and then launch an issue
• I think this rule should be applicable only for some cases (to be identified) : for example, use a test of existence or not of a file (or directory) instead of using a try catch based on FileNotFoundException

by the other hand, this rule is not present in 4th edition of 115 rules (see RULES.md).

to conclude, for me, this rule has to be refactored to do real good things.

[jycr]

If everyone agrees that the rule is currently not appropriate, why not just delete it?
We can work on it later (inspired by what has been developed by looking at the Git history).

[dedece35]

Hi @jycr,
the error message was modifier in 1.2.0 version to "Avoid using try-catch" instead of "Avoid using try-catch-finally" as asked for.
this rule is only implemented for PHP and Python plugin.

TO DISCUSS IN CORE TEAM :

• do we keep this rule ? and make Java implementation also ?
• do we delete this rule ?

[glalloue]

OK to delete this rule (seen with Julien, Maxime, David)

[dedece35]

check TODOs on #128

[dedece35]

close because the work is done in #128