Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC34 replaced by EC35 : python implementation #6

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Oct 21, 2023

2nd PR for TODO tasks mentionned in PR green-code-initiative/creedengo-rules-specifications#128

DONE - waiting for new release of rules-specifications before merging this PR ... see PR green-code-initiative/creedengo-rules-specifications#236 : once merged and a new manual release fo ecocode-rules-specifications done, use it on pom.xml

@dedece35 dedece35 requested review from glalloue and jhertout October 21, 2023 21:41
@dedece35 dedece35 self-assigned this Oct 21, 2023
@dedece35 dedece35 added 🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug labels Oct 21, 2023
@dedece35 dedece35 marked this pull request as draft October 21, 2023 21:43
@dedece35 dedece35 changed the title Ec34 replace EC34 replaced by EC35 : python inplementation Oct 21, 2023
@dedece35 dedece35 changed the title EC34 replaced by EC35 : python inplementation EC34 replaced by EC35 : python implementation Oct 21, 2023
@dedece35 dedece35 marked this pull request as ready for review October 27, 2023 19:27
@dedece35 dedece35 requested a review from utarwyn October 27, 2023 19:37
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok for me. Maybe you should update the CHANGELOG to tell that the rule has been replaced?

@dedece35 dedece35 requested a review from utarwyn October 28, 2023 20:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.8% 83.8% Coverage
0.0% 0.0% Duplication

@dedece35 dedece35 merged commit 39996e7 into main Oct 29, 2023
3 checks passed
@dedece35 dedece35 deleted the EC34-replace branch October 29, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants