Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EC89] Avoid using function cache without limit #26

Closed
Flow35650 opened this issue May 30, 2024 · 1 comment · Fixed by #27
Closed

[EC89] Avoid using function cache without limit #26

Flow35650 opened this issue May 30, 2024 · 1 comment · Fixed by #27
Assignees
@dedece35 @Flow35650
Labels
🗃️ rule rule improvment or rule development or bug

Comments

@Flow35650
Copy link

Description:
If a function has decorators without max size cache, the program will store unlimited datas

Solution:
To warn the developer about this cache bad habit, we have to add a new rule on the following decorators:

  • @cache
  • @lru_cache(maxsize=None)

Additional context:
Problem discussed with @dedece35 during ecoCode Challenge 24. Initially based on the issue CRPYT204 in kanban board
B3ND3L added a commit to B3ND3L/ecoCode-python that referenced this issue May 30, 2024
@B3ND3L
[Issue green-code-initiative#26][EC1337] Avoid unlimited cache
a63dca9
This was referenced May 30, 2024
Merged
Merged
Merged
B3ND3L added a commit to B3ND3L/ecoCode-python that referenced this issue May 31, 2024
@B3ND3L
[Issue green-code-initiative#26][EC1337] Avoid unlimited cache
36da423
@dedece35 dedece35 self-assigned this Jun 2, 2024
@dedece35 dedece35 added the 🗃️ rule rule improvment or rule development or bug label Jun 2, 2024
@dedece35
Copy link
Member

dedece35 commented Jun 2, 2024 •
edited
Loading

Hi @B3ND3L, @Flow35650

please see my review feedback in PR green-code-initiative/creedengo-rules-specifications#327

@dedece35 dedece35 assigned Flow35650 and dedece35 and unassigned dedece35 Jun 2, 2024
B3ND3L added a commit to B3ND3L/ecoCode-python that referenced this issue Jun 3, 2024
@B3ND3L
[Issue green-code-initiative#26][EC89] Change EC1337 to EC89
2699303
B3ND3L added a commit to B3ND3L/ecoCode-python that referenced this issue Jun 3, 2024
@B3ND3L
[Issue green-code-initiative#26][EC89] Typo in changelog.md
d259da4
@dedece35 dedece35 changed the title [EC1337] Avoid using function cache without limit [EC89] Avoid using function cache without limit Jun 3, 2024
@dedece35 dedece35 linked a pull request Jun 3, 2024 that will close this issue
[Issue #26][EC89] Avoid unlimited cache #27
Merged
B3ND3L added a commit to B3ND3L/ecoCode-python that referenced this issue Jun 5, 2024
@B3ND3L
[Issue green-code-initiative#26][EC89] Changer version ecocode-rules …
316958a 
…to 1.6.0
dedece35 added a commit that referenced this issue Jun 5, 2024
@dedece35
Merge pull request #27 from B3ND3L/main
c077c88 
[Issue #26][EC89] Avoid unlimited cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dedece35 dedece35

@Flow35650 Flow35650

Labels
🗃️ rule rule improvment or rule development or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #26][EC89] Avoid unlimited cache B3ND3L/ecoCode-python
2 participants
@dedece35 @Flow35650