[EC22] - check relevance of this rule

[Mester766]

Hi, on my symfony project, we have many code smells coming from this rule and i wonder if she is relevant to php.

For example, we have issues coming from file_exists or filemtime which are definitely not basic operations.

On the other hand, calling a function which only do a basic mathematic operation is clearly a code smell.

So I wonder if there is a relevance for this rule or if it could be enhanced so it does not match on non basic operations.

Thanks for your reply,

[dedece35]

hi @Mester766 , thank you for issue.
clearly, we are missing PHP experts, and Symphony experts.
Could you give some screenshots to prove it, please ?
You can also open a PR with improvments to change rule implémentation if you have some ideas. But maybe, you only want to delete this rule for php ... ?!
thank you.
regards.
David.

[Mester766]

Hi @dedece35,
As you can see here, some complex operations are recognized as basic ones :

I will try some time to make my own rule and make a proposition through PR but i think that for now this rule makes more fake positive than real ones.

Thank you,

[dedece35]

Hi @Mester766 ,

I'm ok with, I think the discussion on the same rule for Java is also quite relevant for PHP : see green-code-initiative/creedengo-rules-specifications#148
I'm going to mark this rule as deprecated to prove the relevance with measurement.
This rule will be deleted on next minor version of plugin.