Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rule image-src-attribute-not-empty #19

Merged
merged 5 commits into from
Aug 10, 2023
Merged

add rule image-src-attribute-not-empty #19

merged 5 commits into from
Aug 10, 2023

Conversation

elisecodedestrucs
Copy link
Contributor

add a rules that forbids the use of without or with an empty src attribute to save CPU usage.

dedece35
dedece35 previously requested changes Jul 21, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dedece35 dedece35 added 🚀 enhancement New feature or request 🗃️ rule Impacts a rule labels Jul 21, 2023
@dedece35 dedece35 requested a review from utarwyn July 21, 2023 15:34
utarwyn
utarwyn requested changes Jul 23, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution too! Also few comments on this one..
Can you also run the linter on added files to fix the build?

eslint-plugin/docs/rules/image-src-attribute-not-empty.md Outdated Show resolved Hide resolved
eslint-plugin/tests/lib/rules/image-src-attribute-not-empty.js Outdated Show resolved Hide resolved
eslint-plugin/docs/rules/image-src-attribute-not-empty.md Outdated Show resolved Hide resolved
@elisecodedestrucs
Copy link
Contributor Author

Thank you for this contribution too! Also few comments on this one.. Can you also run the linter on added files to fix the build?

When I run the linter it raises errors on files I haven't changed, I don't know what to make of it?

@utarwyn
Copy link
Member

utarwyn commented Jul 25, 2023

@elisecodedestrucs
When I run the linter it raises errors on files I haven't changed, I don't know what to make of it?

You can install the prettier plugin in your IDE to format automatically files when you save them (more info here).
Otherwise, you can see the errors raised by the build script directly from GitHub here

@elisecodedestrucs elisecodedestrucs force-pushed the image-src-attribute-not-empty branch from 853b465 to 4b60556 Compare July 25, 2023 14:41
utarwyn
utarwyn approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Can you also propose a test case for this rule in the test project?

utarwyn
utarwyn requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct conflicts? (due to the merge of #18)

@utarwyn utarwyn requested a review from dedece35 August 9, 2023 20:42
@elisecodedestrucs elisecodedestrucs force-pushed the image-src-attribute-not-empty branch from 1f02dfb to de5cc79 Compare August 10, 2023 14:06
@utarwyn utarwyn dismissed dedece35’s stale review August 10, 2023 20:09

Changelog OK

@utarwyn utarwyn merged commit 72dfdf4 into green-code-initiative:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

@dedece35 dedece35 Awaiting requested review from dedece35

Assignees

@elisecodedestrucs elisecodedestrucs

Labels
🚀 enhancement New feature or request 🗃️ rule Impacts a rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elisecodedestrucs @utarwyn @dedece35