Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License and source headers update #11

Merged
merged 3 commits into from
Jul 2, 2023
Merged

License and source headers update #11

merged 3 commits into from
Jul 2, 2023

Conversation

zippy1978
Copy link
Contributor

Work done:

  • changed license from LGPL v3 to GPL v3
  • updated org name to green-code-initiative
  • updated all source headers

@zippy1978 zippy1978 requested a review from olegoaer June 12, 2023 10:58
pom.xml Outdated
<organization>
<name>Green code Initiative</name>
<name>green-code-initiative</name>
<url>https://collectif.greenit.fr</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change also organization URL please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@dedece35 dedece35 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ... for me, to be the same as standard ecoCode and make a reference to our github and not greenit.fr. not good idea ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and our organization is "Green Code Initiative" and not "greenIt" :p
you aren't ok with my idea ? if not, why ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's fine !
I do it !

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zippy1978 zippy1978 requested a review from dedece35 June 22, 2023 11:44
@utarwyn
Copy link
Member

utarwyn commented Jun 30, 2023

Any news on this? Maybe we can merge and create a release?

@dedece35
Copy link
Member

dedece35 commented Jul 2, 2023

Any news on this? Maybe we can merge and create a release?

Hello @utarwyn and @zippy1978 ... ok for me.
ok for you @zippy1978 to merge ?

@zippy1978
Copy link
Contributor Author

Yes,
I merge it

@zippy1978 zippy1978 merged commit 2d4111c into main Jul 2, 2023
@zippy1978 zippy1978 deleted the fix/license branch July 2, 2023 19:48
@dedece35
Copy link
Member

dedece35 commented Jul 2, 2023

@zippy1978 if github action is ok, are you ok that I create a release ?
i will update CHANGELOG with this pR :p

@zippy1978
Copy link
Contributor Author

Yes, go ahead @dedece35 !

@dedece35
Copy link
Member

dedece35 commented Jul 2, 2023

in progress ... :p

@dedece35 dedece35 added 🚀 enhancement New feature or request 🗒️ documentation Improvements or additions to documentation labels Jul 2, 2023
@dedece35
Copy link
Member

dedece35 commented Jul 2, 2023

hi @utarwyn @zippy1978 @olegoaer @jhertout @glalloue
after some updates / corrections with release process int this repository, the first release is OK with 1.1.0 version of ios plugin :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request 🗒️ documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants