From 1d008fdd1b4c9f77df9de24d1991ecee54aed7a1 Mon Sep 17 00:00:00 2001
From: Oussama <oussamala72@gmail.com>
Date: Fri, 16 Dec 2022 21:19:04 +0100
Subject: [PATCH] Fix dependency

---
 java-plugin/pom.xml                                    |  7 ++++++-
 php-plugin/pom.xml                                     | 10 ++++++++++
 php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java  |  3 ---
 pom.xml                                                |  8 +++++---
 python-plugin/pom.xml                                  |  3 ---
 .../l10n/python/rules/python/DefaultProfilePath.json   |  3 +++
 6 files changed, 24 insertions(+), 10 deletions(-)
 create mode 100644 python-plugin/src/main/resources/fr/cnumr/l10n/python/rules/python/DefaultProfilePath.json

diff --git a/java-plugin/pom.xml b/java-plugin/pom.xml
index 48c0fa7fb..e9eb695b6 100644
--- a/java-plugin/pom.xml
+++ b/java-plugin/pom.xml
@@ -27,6 +27,11 @@
             <artifactId>sonar-plugin-api</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>org.sonarsource.sonarqube</groupId>
+            <artifactId>sonar-plugin-api-impl</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>org.sonarsource.analyzer-commons</groupId>
             <artifactId>sonar-analyzer-commons</artifactId>
@@ -68,7 +73,7 @@
             <artifactId>assertj-core</artifactId>
             <scope>test</scope>
         </dependency>
-        
+
     </dependencies>
 
     <build>
diff --git a/php-plugin/pom.xml b/php-plugin/pom.xml
index fd2e31d33..6a96fee9b 100644
--- a/php-plugin/pom.xml
+++ b/php-plugin/pom.xml
@@ -26,6 +26,16 @@
             <artifactId>sonar-plugin-api</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>org.sonarsource.sonarqube</groupId>
+            <artifactId>sonar-plugin-api-impl</artifactId>
+        </dependency>
+
+        <dependency>
+            <groupId>org.sonarsource.analyzer-commons</groupId>
+            <artifactId>sonar-analyzer-commons</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
diff --git a/php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java b/php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java
index 62e42376e..3cc9785c2 100644
--- a/php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java
+++ b/php-plugin/src/main/java/fr/cnumr/php/MyPhpRules.java
@@ -20,15 +20,12 @@
 package fr.cnumr.php;
 
 
-import com.google.common.collect.ImmutableList;
-import fr.cnumr.php.checks.*;
 import org.sonar.api.SonarEdition;
 import org.sonar.api.SonarQubeSide;
 import org.sonar.api.SonarRuntime;
 import org.sonar.api.internal.SonarRuntimeImpl;
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.api.utils.Version;
-import org.sonar.plugins.php.api.visitors.PHPCustomRuleRepository;
 import org.sonarsource.analyzer.commons.RuleMetadataLoader;
 import java.util.ArrayList;
 import java.util.Collections;
diff --git a/pom.xml b/pom.xml
index 1b27df628..f27f99481 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,8 +58,8 @@
 		<sonar.python.version>3.9.0.9230</sonar.python.version>
 		<sonarphp.version>3.3.0.5166</sonarphp.version>
 		<sonar-packaging.version>1.20.0.405</sonar-packaging.version>
-    
-    <junit.version>4.13.2</junit.version>
+
+		<junit.version>4.13.2</junit.version>
 		<junit.jupiter.version>5.9.1</junit.jupiter.version>
 		<assertJ.version>3.23.1</assertJ.version>
 
@@ -80,12 +80,14 @@
 				<groupId>org.sonarsource.analyzer-commons</groupId>
 				<artifactId>sonar-analyzer-commons</artifactId>
 				<version>${sonar-analyzer-commons.version}</version>
+				<scope>compile</scope>
 			</dependency>
 
 			<dependency>
 				<groupId>org.sonarsource.sonarqube</groupId>
 				<artifactId>sonar-plugin-api-impl</artifactId>
 				<version>${sonar-plugin-api-impl.version}</version>
+				<scope>compile</scope>
 			</dependency>
 
 			<!-- JAVA -->
@@ -190,9 +192,9 @@
 
 	<modules>
 		<!-- <module>ecolinter-plugin</module> -->
+		<module>python-plugin</module>
 		<module>java-plugin</module>
 		<module>php-plugin</module>
-		<module>python-plugin</module>
 		<!-- <module>xml-plugin</module> -->
 	</modules>
 
diff --git a/python-plugin/pom.xml b/python-plugin/pom.xml
index 7bf34f6f7..e3b9aa96b 100644
--- a/python-plugin/pom.xml
+++ b/python-plugin/pom.xml
@@ -26,13 +26,10 @@
             <groupId>org.sonarsource.sonarqube</groupId>
             <artifactId>sonar-plugin-api</artifactId>
         </dependency>
-
         <dependency>
             <groupId>org.sonarsource.sonarqube</groupId>
             <artifactId>sonar-plugin-api-impl</artifactId>
-            <scope>compile</scope>
         </dependency>
-
         <dependency>
             <groupId>org.sonarsource.analyzer-commons</groupId>
             <artifactId>sonar-analyzer-commons</artifactId>
diff --git a/python-plugin/src/main/resources/fr/cnumr/l10n/python/rules/python/DefaultProfilePath.json b/python-plugin/src/main/resources/fr/cnumr/l10n/python/rules/python/DefaultProfilePath.json
new file mode 100644
index 000000000..c00983472
--- /dev/null
+++ b/python-plugin/src/main/resources/fr/cnumr/l10n/python/rules/python/DefaultProfilePath.json
@@ -0,0 +1,3 @@
+{
+"ruleKeys": ["S69"]
+}
\ No newline at end of file