Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup controller code #4

Open
grawin opened this issue Mar 10, 2017 · 0 comments
Open

Cleanup controller code #4

grawin opened this issue Mar 10, 2017 · 0 comments
Assignees
@grawin
Labels
enhancement

Comments

@grawin
Copy link
Owner

grawin commented Mar 10, 2017

Move any extra code out of the controllers and into the services. For example the login service has some extra logic in there that should probably be part of the service (e.g. checking for valid ID). Also the connection controller has some extra logic and duplicate functionality.
@grawin grawin self-assigned this Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grawin grawin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grawin