Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icon size consistent #974

Closed
matthijsmelissen opened this issue Sep 24, 2014 · 6 comments
Closed

Make icon size consistent #974

matthijsmelissen opened this issue Sep 24, 2014 · 6 comments

Comments

@matthijsmelissen
Copy link
Collaborator

Add the moment, we are using a mixture of 16px, 20px, and even 24px icons, without clear reasoning why some icons are bigger than others.

Would using the 16px versions for all icons be an improvement?

Here an overview of all icons in different sizes can be found: http://www.sjjb.co.uk/mapicons/contactsheet

@mboeringa
Copy link

The 16px seems reasonable: as small as possible to save space, but still readable. The 12px definitely will be to small for on-screen display like on the main OSM website I think, and for the elderly with less than optimal eye-sight.

Maybe a couple of icons could be chosen bigger though, like the B&B. I wouldn't necessarily stay to strictly at the 16px for all icons if they are not so clear at 16px.

@pnorman
Copy link
Collaborator

pnorman commented Sep 24, 2014

The icons which are 16px may also have transparent pixels around the edges, so a simple image size is hard to give.

@matthijsmelissen
Copy link
Collaborator Author

See also #630.

@kocio-pl
Copy link
Collaborator

We now have a 14px as a standard, I guess this issue can be closed now.

@matthijsmelissen
Copy link
Collaborator Author

It seems like we still have a couple of 'old' icons with different sizes, like for golf and slipway.

Also, it seems some of the icons are 14px, and others are 16px including a white border. It would be nice if we could unify that too.

@kocio-pl
Copy link
Collaborator

Now I doubt if that's possible - like I said in #1145 (comment), we have some 20 px icons (slipway - probably it's hard to make it smaller without compromising readability) and some 10 px (waste basket - by design).

I can live with that and I think it's enough to have a common size mentioned in our icon guidelines.

@kocio-pl kocio-pl self-assigned this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants