Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding bridges for higher-zoom ref labeling #701

Closed
pnorman opened this issue Jul 4, 2014 · 5 comments
Closed

Excluding bridges for higher-zoom ref labeling #701

pnorman opened this issue Jul 4, 2014 · 5 comments
Assignees
Labels

Comments

@pnorman
Copy link
Collaborator

pnorman commented Jul 4, 2014

Currently the #roads-text-ref layer uses the following selectors (svg_shields branch)

  [highway = 'motorway'][length < 12] {
    [zoom >= 13] {
      ...
    }
  }
  [highway = 'trunk'][zoom >= 13] {
    ...
  }
  [highway = 'primary'][zoom >= 13] {
    ...
  }
  [highway = 'secondary'][bridge = 'no'][zoom >= 13] {
    ...
  }
  [highway = 'tertiary'][bridge = 'no'][zoom >= 13] {
    ...
  }
  [highway = 'unclassified'],
  [highway = 'residential'] {
    [zoom >= 15][bridge = 'no'] {
      ...
    }
  }
  [highway = 'runway'],
  [highway = 'taxiway'] {
    [zoom >= 15][bridge = 'no'] {
      ...
    }
  }

bridge = 'no' is true for bridge values other than yes, true, or 1. I've tried to figure out the logic here, but find none. @gravitystorm, do you have any ideas? I presume this is carried over from the old Mapnik XML.

All I can think of is an attempt to stop labeling small components. But then why only some highway types?

@gravitystorm
Copy link
Owner

I don't have any reasoning, it's just carried over. Perhaps the black text clashes with the black bridge outlines? Whichever, it should be consistent.

@matthijsmelissen
Copy link
Collaborator

I think the reason is that bridge segments are usually very short, so this might result in repetition of the same name on a small interval.

@matthijsmelissen matthijsmelissen self-assigned this Jul 20, 2014
@AndrewHain
Copy link
Contributor

Segments without room to display a name will in any case not have one, whether they are one way, bus routes or whatever, no need for a special case for bridges.

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 20, 2014

Segments without room to display a name will in any case not have one

This is true for TextSymbolizers, but I don't think it's true for ShieldSymbolizers.

@matthijsmelissen
Copy link
Collaborator

@pnorman Can I assign this issue to you?

@pnorman pnorman closed this as completed in cd7da91 Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants