bridge=yes renders over bridge=viaduct

[matkoniecz]

[highway=tertiary + bridge=yes] renders over [highway=tertiary + bridge=viaduct]
[highway=tertiary] renders under [highway=tertiary]
Value of bridge key influences ordering what should not happen.

[highway=tertiary + bridge=viaduct] renders over [highway=tertiary_link + bridge=yes]
so original example is now not working

original report:

highway=tertiary renders over highway=primary

http://www.openstreetmap.org/?mlat=50.07349&mlon=19.94481#map=17/50.07349/19.94481

http://www.openstreetmap.org/way/25381783

http://www.openstreetmap.org/way/19843581

[matthijsmelissen]

That's a tagging mistake: 25381783 and the part below should be tertiary_link instead of tertiary.

[Rovastar]

Not a tagging mistake like that math. (It should/could be a tert link but it is case that tert road is rendering over a primary and that is questionable)
I had a look at this and did a test.
This is a bridge issue. They are both bridges. But the primary is (well was, I just changed) bridge=viaduct and the tert road is bridge=yes.
The issue appears to be actually bridge=yes renders over bridge=viaduct.
Changed to both bridge = yes render as expected primary over tertiary.
Now I am not sure what should be the order here (I know little about bridge = viaduct and how we should render) but that seems to be the issue.
I'll change the primary back to bridge=viaduct shortly.

[Rovastar]

I have changed this to
highway=primary and bridge=viaduct
and
highway=tertiary_link and bridge=yes
and the problem disappears. But I suspect that this is because link roads render under everything else.

[matthijsmelissen]

Thanks for the extensive test - you convinced me it's a bug. We don't intend to treat bridge=yes different from bridge=viaduct. Probably there is some inconsistency in the bridge SQL queries somewhere.

[Rovastar]

yeah probably but I imagine it doesn't happen too often.

mkoniecz, I have left this as a tertiary_link road for now as IMHO it should be that but I'll let you edit it as you see fit for your area.

[matkoniecz]

I rephrased title to "bridge=yes renders over bridge=viaduct" and summarized what happens in top comment. Thanks for an investigation.

[matthijsmelissen]

This is a problem with osm2pgsql. Roads with bridge=yes get 10 added to the z_order, btt roads with bridge=viaduct don't. Pull request #462 will solve this.

[pnorman]

#626 is the PR, #462 is the issue which has some overlap with this.

[matthijsmelissen]

Resolved by #626.

[matthijsmelissen]

Confirmed that the linked problem is solved.

[matkoniecz]

Note that linked problem was already solved by "I have left this as a tertiary_link road for now".